chore: Add more lints #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as neqo.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 86.46% 86.71% +0.25%
==========================================
Files 5 5
Lines 554 557 +3
Branches 554 557 +3
==========================================
+ Hits 479 483 +4
- Misses 47 48 +1
+ Partials 28 26 -2 ☔ View full report in Codecov by Sentry. |
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
mxinden
approved these changes
Jan 14, 2025
build.rs
Outdated
Comment on lines
73
to
74
| let out_path = std::path::PathBuf::from(std::env::var("OUT_DIR").unwrap()).join(BINDINGS); | ||
| let out_path = | ||
| std::path::PathBuf::from(std::env::var("OUT_DIR").unwrap_or_default()).join(BINDINGS); |
There was a problem hiding this comment.
If OUT_DIR isn't set, this would write to ./bindings.rs?
There was a problem hiding this comment.
Yeah. A panic is probably better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as neqo.